Add more flaky files to exception list in CI - #41235
Conversation
|
this mechanism is too coarse-grained (it retries the whole set of files instead of just the one flaky test), but adding per-test flaky marker takes some work... I don't like having two separate lists (one for the mapping, the other for the files) though. Ideas? |
|
actually there's an "easy" solution for per-test flaky that doesn't sacrifice other tests in the same file: add As I mentioned, most of these tests only cause a Python-handle-able error on failure. |
|
Documentation preview for this PR (built with commit 3629d52; changes) is ready! 🎉 |
Perhaps, but on the other hand we sometimes don't even know what exact doctest is triggering the flaky behavior (or there might be more than one tests in a file that triggers it). Once we have more refined tools, we can easily remove those file-based retries again.
Me neither, but that was the best I could do given the limitations of the gh actions yml format (it doesn't accept comments in lists). |
|
Some of these are outdated, @cxzhong has been working to fix them, e.g.
|
Thanks, this list was indeed quite outdated. Synced it now again with https://github.com/orgs/sagemath/projects/1/views/1. |
|
One less to worry about: #42395 |
|
And #41008 was fixed by the switch to HiGHS as the default MILP solver. |
|
Another one down in #42400 |
|
The project https://github.com/orgs/sagemath/projects/1 is marked private so links to it may not work (if the user is not logged in to github). Is that something you can change, or do we have to ask the admins? |
Add all flaky tests tracked at https://github.com/orgs/sagemath/projects/1 to the list in CI, so that those get automatically rerun in case of (random) failure.
📝 Checklist
⌛ Dependencies