Implement relative Frobenius for Drinfeld modules - #40432
Conversation
|
Documentation preview for this PR (built with commit d315182; changes) is ready! 🎉 |
kryzar
left a comment
There was a problem hiding this comment.
Two minor changes and then we'll be good.
Co-authored-by: Antoine Leudière <clapped.hesitancy332@anonaddy.me>
|
I applied your suggestions. |
|
It's really tedious and frustrating going through each build or test fail individually, just to inevitably note that the problem comes either from internal machinery or a contribution that was not caught. I really hope the maintainers do something about that. PR approved. |
|
Why are you deleting conftest.py? |
Sorry. It always disappear by itself, I don't know why. |
I'm frustrated too. I tried to implement #39539 as a workaround, but it isn't working and I don't know why. For now, I mostly just look at the meson one and if say at most 2 of them are failing then it's probably just flaky tests. This doesn't work with build-doc or build-doc-pdf however, there's only one run of it. Doesn't help that you need to search through a huge log file for the error.
Strange. After #39363 there should be no issue with it. Unless… the pull request itself is responsible for the disappearing file. As a workaround (I of course encourage proper fix, but we don't have enough people to look at all these bugs, unfortunately) you can |
|
actually the established macro is (this macro is available for you to use) |
|
Actually, we already use |
|
I mean, if people decide mathbb is better than mathbf, it's trivial to change the definition of the … but whatever, let's get this in. (if build-doc-pdf is successful and no missing character error) |
|
Thanks very much @user202729 for the help and many tips. It's nice. |
|
Looks like the failures are again not related to the PR. |
Me too!!! |
sagemathgh-40432: Implement relative Frobenius for Drinfeld modules This PR implements the relative Frobenius for Drinfeld modules. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430 URL: sagemath#40432 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Volker Braun, Xavier Caruso

This PR implements the relative Frobenius for Drinfeld modules.
📝 Checklist
⌛ Dependencies
#40430