Skip to content

Fix -Wunterminated-string-initialization warning in ulong_to_str - #245

Open
cxzhong wants to merge 1 commit into
sagemath:mainfrom
cxzhong:fix-wunterminated-string-initialization
Open

Fix -Wunterminated-string-initialization warning in ulong_to_str#245
cxzhong wants to merge 1 commit into
sagemath:mainfrom
cxzhong:fix-wunterminated-string-initialization

Conversation

@cxzhong

@cxzhong cxzhong commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

Replace string literal with explicit char array initializer to avoid the -Wunterminated-string-initialization warning from GCC15.
fix

[8/15] Compiling C object src/cys...ated_src_cysignals_signals.pyx.c.o
In file included from src/cysignals/signals.cpython-314-x86_64-linux-gnu.so.p/src/cysignals/signals.pyx.c:1133:
../../src/cysignals/implementation.c: In function ‘ulong_to_str’:
../../src/cysignals/implementation.c:163:30: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (17 chars into 16 available) [-Wunterminated-string-initialization]
  163 |     const char xdigits[16] = "0123456789abcdef";
      |                              ^~~~~~~~~~~~~~~~~~

Replace string literal with explicit char array initializer to avoid
the -Wunterminated-string-initialization warning from GCC.
@cxzhong
cxzhong requested a review from tornaria April 5, 2026 08:55
Comment thread src/cysignals/implementation.c
@cxzhong
cxzhong requested a review from tornaria April 6, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants