Add ubuntu-24.04-arm to CI workflow matrix and build wheels for free-threading - #241
Add ubuntu-24.04-arm to CI workflow matrix and build wheels for free-threading#241cxzhong wants to merge 7 commits into
Conversation
cxzhong
changed the title
…threading - Add ubuntu-24.04-arm runner to CI and dist workflow matrices - Enable free-threading (cpython-freethreading) in cibuildwheel - Add Python 3.14t to CI test matrix - Update CI workflows to use latest action versions (actions/checkout@v4, actions/setup-python@v5, actions/download-artifact@v4, actions/upload-artifact@v4) - Update minimum Python version requirement to 3.12 - Fix compatibility issues with Python 3.14 - Upgrade dependencies (meson, meson-python, Cython) in pyproject.toml - Auto-generate cysignals.pc from cysignals.pc.in via meson configure_file - Bump version to 1.12.6 - Fix release workflow by removing duplicate macOS building and migrating to Trusted Publisher - Add macos-15-intel to dist workflow
bde3d3a to
bc91613
Compare
Removed macOS 15 and Ubuntu 24.04 ARM from CI matrix.
tobiasdiez
left a comment
tobiasdiez
left a comment
There was a problem hiding this comment.
I don't have time for a proper review atm (eg test the changes), but the code changes look reasonable to me.
|
Maybe split the lint step to a later PR, document there how you run the linter, and perhaps add a lint check to CI? Note that @tobiasdiez reviewed it before the lint step. Also, I prefer rebase than merges, as it makes things easier to review. It's a matter of taste, but I'd rather have PRs that do one thing. The PR itself is documentation for the future so be explicit about everything you do in the PR. Your commit message for bc91613 is already much more detailed, at the very least you should copy this to the PR message. Some changes seem ok to sneak in, but some changes maybe need to be more explicit, e.g. minimum version requirements for python and cython (python is most likely ok, although is it necessary? otoh, cython 3.1 is less than one year old). From your log message "Fix compatibility issues with Python 3.14" can you elaborate? |
|
the minimum python requirement is sepc000. and the minimum cython requirement is since only cython>3.1.0, we can use free threading directive. |
|
Maybe I will going to 2-3 PRs about this |
But it should still be possible to build the package with older cython (for a non free-threading python)? |
I have added |
3 participants
Fix #240 I also lint the meson.build file