Accept CryptoKey in ResultsReader; unwrap CEK via crypto.subtle#21
Open
jpslav wants to merge 1 commit into
Open
Accept CryptoKey in ResultsReader; unwrap CEK via crypto.subtle#21jpslav wants to merge 1 commit into
jpslav wants to merge 1 commit into
Conversation
…pKey
ResultsReader previously required the recipient's private key as a raw PKCS#8 ArrayBuffer, forcing any consumer that wanted to hold an unlocked key longer than a single decrypt to keep raw key bytes resident in JS memory. Internally the per-file AES content-encryption key was also recovered via crypto.subtle.decrypt + importKey('raw', ...), so the CEK briefly materialized as raw bytes on every file unwrap regardless of how the private key was held.
nathanstitt
approved these changes
May 5, 2026
nathanstitt
left a comment
nathanstitt
left a comment
Member
There was a problem hiding this comment.
this seems good to me.
I think we'd discussed using this as part of using passkeys, but decided against it for v0. Perhaps it's time to expand support for those as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResultsReader previously required the recipient's private key as a raw PKCS#8 ArrayBuffer, forcing any consumer that wanted to hold an unlocked key longer than a single decrypt to keep raw key bytes resident in JS memory. Internally the per-file AES content-encryption key was also recovered via crypto.subtle.decrypt + importKey('raw', ...), so the CEK briefly materialized as raw bytes on every file unwrap regardless of how the private key was held.