fix(make): point build and test at xcodebuild, document the commands - #13
Conversation
The Makefile called swift build/test/run, but this is an Xcode project with no Package.swift, so every target failed with "Could not find Package.swift". A cold pickup that tried make test hit a dead end. Retargets build/test at the same xcodebuild invocation CI uses, including the same first-available-iPhone-simulator lookup. run now opens the project in Xcode, since an iOS app bundle cannot be launched from the CLI. clean uses xcodebuild clean instead of removing a SwiftPM .build directory that never existed. CLAUDE.md's Build / Test / Run section had no commands in it; it now carries these plus the separate DataPipeline suite. Verified: make test green at 55 tests, 5 skipped by design, and DataPipeline at 5 passed.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68dd225e7d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| and has its own fast suite: | ||
|
|
||
| ```sh | ||
| python3 -m pytest DataPipeline/test_pipeline.py # 5 tests, <1s |
There was a problem hiding this comment.
In a clean Python environment created from DataPipeline/requirements.txt, this documented command fails because pytest is not listed as a dependency. The test module already uses unittest and has a unittest.main() entry point, so document python3 DataPipeline/test_pipeline.py (or declare pytest as a development dependency) to keep the advertised test workflow reproducible.
Useful? React with 👍 / 👎.
1 participant
Every Makefile target called swift build/test/run, but this is an Xcode project with no Package.swift, so all of them failed. Retargets build/test at the same xcodebuild invocation CI uses. run now opens the project in Xcode. Verified: make test green at 55 tests, 5 skipped by design; DataPipeline 5 passed.