am4: fix amp-edit crash, enable block place/remove + palette#31
Merged
Conversation
- Composite (pidLow<<16)|pidHigh id encoding for block params so amp and cab sub-blocks no longer collide on bare pidHigh — fixes the each_key_duplicate crash when opening the Amp editor, and the latent cab-write mis-addressing. setParam() decodes the composite back. - Bump bypass sentinel to 0xffff (above every bare pidHigh, below every composite id) so it can't collide either. - Implement placeCell() via buildSetBlockType(slot, id): place/change a block, and clear a slot (id 0) — enables delete + change amp. - Implement blocksCatalog() so the add-FX palette is populated. - Capability gridEdit: true (slot block-type write); decouple gridRouting from gridEdit in registryCore (routing = cable, which AM4 lacks) so caps stay accurate. - Report the actually-active driver in the detect log instead of leaking the vestigial gen-3 profile key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the remaining AM4 (model 0x15) fix on top of the portable-runtime release already merged to
main.What's included
f47c3b7)The rest of AM4 support (device profile, gen-3 gating, param read/write, driver architecture) already reached
mainvia PRs #29/#30. This is the outstanding follow-up fix.🤖 Generated with Claude Code