[BUGFIX]: add lowercase alias ext:<extensionname> for SCSS imports - #41
Open
luisbecker-gh wants to merge 3 commits into
Open
[BUGFIX]: add lowercase alias ext:<extensionname> for SCSS imports#41luisbecker-gh wants to merge 3 commits into
luisbecker-gh wants to merge 3 commits into
Conversation
Owner
|
I haven't tested it myself, but your approach sounds reasonable. Could you adjust the unit tests to get the pipeline green? I'll probably add a integration test after that to verify the sass behavior (you can of course also tackle this, feel free to contact me for help) |
Author
|
The unit tests are fixed, I also had a go at the integration test. I had to add sass as dev-dependency. Let me know if you want it to be a seperate test instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@import/@use Statements in SCSS do no work with the "EXT:" Syntax but with "@" it worked just fine. I discovered, that the SCSS resolve function always gets the import filepath as lowercase string.
Example:
@import "EXT:sitepackage"would match a alias likeext:sitepackagebut not the existing aliasEXT:sitepackageThis commit adds an additional alias with the lowercase
ext:, so SCSS can resolve the files correctly.Could you please verify my results and are there any concerns about extending the aliases that way?
Thank you!
I tested with:
npm packages:
vite@8.0.13
vite-plugin-typo3@3.0.0
sass-embedded@1.99.0
TYPO3:
TYPO3 13.3.33
praetorius/vite-asset-collector 1.18.1
Fixes: #19