Allow to set custom atime and mtime - #133
Open
invernizzi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SETATTRsystem calls that set a custom atime on an inode (e.g.,touch -t 0102030405 a.txt) set both theSETATTR_ATIMEandSETATTR_ATIME_SETflags.Prior to the fix, SETATTR_ATIME_SET was processed first, setting the custom
atimecorrectly.Then, SETATTR_ATIME was processed, which updated the
atimeto the current time.This execution order was essentially overwriting the custom
atimeimmediately. The fix executes the two instructions in the correct order, and fixes a typo (anatimethat should have been anmtime).Before the fix:
After the fix:
(Thanks for an awesome project!)