Claude/cleanup dotfiles repo 011 c uw82c97 md h4g m5wf9 a ag#2
Closed
ryanwclark1 wants to merge 2 commits into
Closed
Claude/cleanup dotfiles repo 011 c uw82c97 md h4g m5wf9 a ag#2ryanwclark1 wants to merge 2 commits into
ryanwclark1 wants to merge 2 commits into
Conversation
Fix config test suite failures in Docker environment by: 1. Updated .dockerignore to keep .gitignore file - Tests check for .gitignore existence and content - Previously excluded, causing test failures 2. Made git-based test Docker-aware in test-configs.sh - Git test now checks if .git directory exists - Gracefully skips test in Docker (no .git directory) - Prevents "not a git repository" errors This ensures all tests pass in both local and Docker CI environments. Fixes GitHub Actions CI Docker test failures.
DevContainer configuration files use JSONC (JSON with Comments) format, which is valid for VS Code but not compatible with strict JSON parsers like jq. Changes: 1. Updated .dockerignore to exclude .devcontainer/ directory - DevContainer files not needed in Docker test builds - Prevents JSONC validation errors 2. Updated GitHub Actions workflow to skip devcontainer files - Excludes .devcontainer/* from JSON validation - Also excludes tmux/plugins/* (third-party code) This allows: - DevContainer files to use comments (JSONC standard) - CI/CD validation to pass - Docker tests to run without JSONC conflicts The .devcontainer/devcontainer.json file legitimately uses: - // comments (JSONC feature) - Trailing commas (JSONC feature) These are intentional and valid for VS Code DevContainers.
ryanwclark1
deleted the
claude/cleanup-dotfiles-repo-011CUw82c97MdH4gM5wf9AAg
branch
November 9, 2025 00:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.