Skip to content

[Snyk] Security upgrade nokogiri from 1.6.8.1 to 1.19.1 - #15

Open
ryanmcmorrowsnyk wants to merge 2 commits into
masterfrom
snyk-fix-96ac6cf7f19a23b7e995c4e8e207c583
Open

[Snyk] Security upgrade nokogiri from 1.6.8.1 to 1.19.1#15
ryanmcmorrowsnyk wants to merge 2 commits into
masterfrom
snyk-fix-96ac6cf7f19a23b7e995c4e8e207c583

Conversation

@ryanmcmorrowsnyk

Copy link
Copy Markdown
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the rubygems dependencies of this project.

Snyk changed the following file(s):

  • Gemfile
⚠️ Warning
Failed to update the Gemfile.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Unchecked Return Value
SNYK-RUBY-NOKOGIRI-15315717
  66  

Breaking Change Risk

Merge Risk: High

Notice: This assessment is enhanced by AI.


Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-RUBY-NOKOGIRI-15315717
@ryanmcmorrowsnyk

Copy link
Copy Markdown
Owner Author

Merge Risk: High

This is a significant major version upgrade for Nokogiri that spans several years of releases and includes numerous breaking changes. The most critical changes involve dropping support for end-of-life Ruby versions.

Key Breaking Changes:

  • Ruby Version Support: Support for many older, end-of-life Ruby versions has been removed. The target version 1.19.1 requires Ruby >= 3.0. If your application is running on an older Ruby version, the upgrade will fail.
    • Support for Ruby 2.6 was dropped in v1.14.0.
    • Support for Ruby 2.0 and 1.9.3 was dropped in v1.7.0.
  • JRuby Support: For JRuby users, the minimum required Java version was raised to 8 in v1.17.0.
  • API Behavior Changes:
    • Namespace Inheritance: A breaking change was introduced in v1.12.0 regarding how namespaces are inherited when nodes are reparented. While this was partially reverted for the Builder API in v1.12.4, the default document behavior changed.
    • SAX Parser: v1.17.0 included significant bug fixes to the SAX parsers. The official changelog warns that applications relying on the previous buggy behavior may be impacted.
    • CData: As of v1.17.0, Nokogiri::XML::CData.new no longer accepts nil and requires an empty string to create an empty node.

Recommendation:

Before merging, you must verify that your application is running on a supported Ruby version (>= 3.0). Due to the subtle API and behavioral changes, thorough testing of XML and HTML parsing, building, and serialization is strongly recommended, especially if you use the SAX parsers or manipulate XML namespaces.

Source: Nokogiri Changelog

Notice 🤖: This content was augmented using artificial intelligence. AI-generated content may contain errors and should be reviewed for accuracy before use.

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-RUBY-NOKOGIRI-15315717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants