Fix failing CI: point keyboard test at renamed kimi-k3 preset - #10
Merged
Conversation
The Kimi K3 preset commit renamed the mixtral-8x7b preset to kimi-k3 in presets.ts and index.html but left the keyboard tab-order test's PRESET_IDS still referencing the removed mixtral chip, so findIndex returned -1 and the a11y test failed across all viewport projects. Point it at the current chip. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RdZJCgjCEYez3bTWjiJ6b
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why main is red
The
checksjob fails onfrontend/tests/keyboard.spec.ts:112("tab order reaches every interactive control without a trap") across all 4 viewport projects —expect(stopIndex).toBeGreaterThanOrEqual(0)gets-1.Root cause: the "Kimi K3 preset" commit (#7) renamed preset
mixtral-8x7b→kimi-k3inpresets.tsandindex.html, but the keyboard test's hardcodedPRESET_IDSlist still referencedmixtral-8x7b. That chip no longer exists, sofindIndexreturns -1. (The dependabot #9 run just inherited the same red.)It's stale test data, not an accessibility regression — the
kimi-k3chip is keyboard-reachable like every other preset.Fix
One line:
PRESET_IDSmixtral-8x7b→kimi-k3.🤖 Generated with Claude Code
https://claude.ai/code/session_014RdZJCgjCEYez3bTWjiJ6b
Generated by Claude Code