#156 - Fix for console error + non-loaded comment editor using touchbased devices in pin mode - #158
Open
danowar2k wants to merge 1 commit into
Open
Conversation
…ing touchbased devices in pin mode
Author
|
Note: I didn't include incrementing the version of index.js in this pull request because one can do so when releasing a new plugin version. |
Author
|
Fixes #156 |
Contributor
|
Thank you for this. This will be incorporated in the next release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the console error from #156 by preloading the comment editor when adding a pin via touch.
Fixing this also brings the add comment textarea in focus (meaning into the viewpoint) in touch mode so that one can directly enter the comment.