Replace innerHTML with secure DOM APIs to prevent XSS#2
Merged
Conversation
Co-authored-by: rwoll <11915034+rwoll@users.noreply.github.com>
Co-authored-by: rwoll <11915034+rwoll@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update code to use secure DOM APIs instead of innerHTML
Replace innerHTML with secure DOM APIs to prevent XSS
Jan 23, 2026
Owner
|
@copilot - Your current code change looks good. Do NOT make any additional changes, but please use the playwright MCP you have available to post a screenshot of the changes in the issue description. |
rwoll
approved these changes
Jan 23, 2026
Copilot stopped work on behalf of
rwoll due to an error
January 23, 2026 01:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
innerHTMLcan lead to XSS vulnerabilities when rendering dynamic content. This PR replaces all three occurrences with secure DOM APIs while maintaining vanilla JS.Changes
renderUpcomingDates(): UsecreateElement(),appendChild(), andtextContentinstead of HTML string interpolationpopulateSelectors(): UseOptionconstructor withselect.add()for both month and year dropdownsBefore
After
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.