Skip to content

chore: broken-kit=P0 rule + CNI validation test plan/results - #828

Open
rustyrazorblade wants to merge 1 commit into
mainfrom
chore/kit-p0-rule-and-cni-validation
Open

chore: broken-kit=P0 rule + CNI validation test plan/results#828
rustyrazorblade wants to merge 1 commit into
mainfrom
chore/kit-p0-rule-and-cni-validation

Conversation

@rustyrazorblade

Copy link
Copy Markdown
Owner

Saves two things before picking #805 back up tomorrow:

Docs/process only — no code. Separate from PR #820 (the #805 implementation).

…dation test plan + results

- CLAUDE.md: a broken kit (failed install/start/health) is ALWAYS a P0, never deferred or scoped out.
- test-plans/cni-flannel-cilium-validation.md: two-CNI acceptance plan (every kit, both CNIs).
- test-plans/cni-flannel-cilium-validation-results.md: partial results (Flannel pass; Cilium blocked on kpr=false hostNetwork->ClusterIP).
- gitignore stray nohup.out / build logs.
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Total Project Coverage 73.28%

@claude

claude Bot commented Jul 21, 2026

Copy link
Copy Markdown

Reviewed — this is a docs/process-only PR (no code changes), so most of the usual review dimensions (code quality, perf, security) don't apply. A few notes:

Inconsistency with test-plans/CLAUDE.md

test-plans/CLAUDE.md mandates that "every plan must ... [c]reate the workspace directory and run bin/create-easy-db-lab-wrapper as its first step," with a literal bash block (CLUSTER_DIR=...; mkdir -p ...; bin/create-easy-db-lab-wrapper ...; EDB=...). Every other file in test-plans/ (e.g. cassandra-5.0-validation-full.md, postgres-kit-validation.md, clickhouse-validation-full.md) includes that literal block as step 1.

test-plans/cni-flannel-cilium-validation.md only mentions the wrapper in prose under "Preconditions" ("Cluster workspace + $EDB wrapper per CLAUDE.md...") and jumps straight to $EDB init ... as "Steps 1." in both phases — there's no actual CLUSTER_DIR=/mkdir -p/bin/create-easy-db-lab-wrapper/EDB= snippet anywhere in the file. Worth adding the literal block to match the convention (and so the plan is directly copy-pasteable via /easy-db-lab:run, consistent with every sibling plan).

Minor / non-blocking

Everything else — the CNI matrix, root-cause writeup for the kubeProxyReplacement=false hostNetwork→ClusterIP gap, and the CNI-independent kit findings (tidb dead helm repo, trino config rejection) — is well-documented and clearly separates #805-specific issues from pre-existing kit bugs. Nothing else to flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant