Add --key-dir flag to configure iroh-ssh key location#40
Merged
Conversation
The irohssh_ed25519 key path was hardcoded to ~/.ssh. Add a --key-dir option to server, info, service install, and run-service commands so users can store keys in a custom directory. When --key-dir is set, the service-specific overrides (/root/.ssh on Linux, ServiceProfiles on Windows) are skipped in favor of the explicit path.
Owner
…ro exit code passed making test fail
The irohssh_ed25519 key path was hardcoded to ~/.ssh. Add a --key-dir option to server, info, service install, and run-service commands so users can store keys in a custom directory. When --key-dir is set, the service-specific overrides (/root/.ssh on Linux, ServiceProfiles on Windows) are skipped in favor of the explicit path.
Owner
|
Todo:
|
Owner
|
Thank you @r-vdp for this PR. Just finished the release: |
Owner
|
Hi @futpib, I have updated iroh-ssh to v0.2.10. If you have some time you can update the arch package. Thank you. |
Contributor
|
@rustonbsd it builds whatever is in your git every time, if it does not fail it's on the latest version, that's how AUR works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
irohssh_ed25519key path was hardcoded to~/.ssh. This adds a--key-diroption to theserver,info,service install, andrun-servicecommands so users can store keys in a custom directory.When
--key-diris set, the service-specific overrides (/root/.sshon Linux,ServiceProfileson Windows) are skipped in favor of the explicit path.The first commit is just
cargo fmton the existing codebase — happy to drop it if you'd prefer to keep formatting separate.