Iroh 98 update#25
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 47 minutes and 45 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates the crate version to 0.3.1, removes the homepage metadata field, and bumps dependencies including Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Cargo.toml`:
- Line 51: The getrandom dependency in Cargo.toml is missing the sys_rng feature
required to expose SysRng and the rand_core re-export used by
src/crypto/record.rs (SysRng and UnwrapErr); update the getrandom entry to
include "sys_rng" in its features (e.g., features = ["std", "sys_rng"]) while
keeping default-features = false so that SysRng and the rand_core items are
available to the code that imports SysRng/UnwrapErr.
- Around line 47-51: The rand dependency in Cargo.toml is missing the
"thread_rng" feature required by calls to rand::rng() (used in tests and
src/gossip/sender.rs); update the rand entry's features list to include
"thread_rng" so the crate builds with thread-local RNG support (i.e., add
"thread_rng" alongside "std" and "std_rng" in the rand = { ... features = [...]
} declaration).
In `@README.md`:
- Around line 14-22: Remove the unused rand dependency from the quick-start
Cargo snippet: delete the line containing "rand = \"0.9\"" so the example's
dependencies match the code (which no longer uses rand for key generation) and
avoid introducing a mismatched/unused direct dependency; update the dependency
list that includes anyhow, tokio, ed25519-dalek, iroh, iroh-gossip, and
distributed-topic-tracker accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0d492a2b-af05-438d-953f-35b14cd53414
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (12)
Cargo.tomlREADME.mdexamples/chat.rsexamples/chat_no_wait.rsexamples/e2e_test.rsexamples/full_config.rsexamples/secret_rotation.rsexamples/simple.rsexamples/without_mergers.rssrc/crypto/record.rssrc/gossip/topic/topic.rstests/tests.rs
Summary by CodeRabbit