Skip to content

Iroh 98 update#25

Merged
rustonbsd merged 3 commits into
mainfrom
iroh-98-update
Apr 20, 2026
Merged

Iroh 98 update#25
rustonbsd merged 3 commits into
mainfrom
iroh-98-update

Conversation

@rustonbsd

@rustonbsd rustonbsd commented Apr 20, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Version bumped to 0.3.1
    • Updated dependencies: ed25519-dalek, iroh, iroh-gossip, and rand
    • Added getrandom dependency
    • Updated examples and tests to reflect API changes

@coderabbitai

coderabbitai Bot commented Apr 20, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@rustonbsd has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 47 minutes and 45 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 47 minutes and 45 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 91c57659-ef6e-40ce-bc51-a2de33b95aee

📥 Commits

Reviewing files that changed from the base of the PR and between 0c076a2 and b814d30.

📒 Files selected for processing (2)
  • Cargo.toml
  • README.md
📝 Walkthrough

Walkthrough

The PR updates the crate version to 0.3.1, removes the homepage metadata field, and bumps dependencies including ed25519-dalek, iroh, iroh-gossip, and adds getrandom. Secret key generation across examples, tests, and internal crypto code is refactored to call SecretKey::generate() without explicit RNG arguments instead of passing &mut rand::rng().

Changes

Cohort / File(s) Summary
Dependency & Version Updates
Cargo.toml, README.md
Incremented version to 0.3.1, removed homepage field. Bumped ed25519-dalek (3.0.0-pre.1 → 3.0.0-pre.6), iroh/iroh-gossip (0.97 → 0.98), rand (0.9 → 0.10), and added getrandom 0.4. Reformatted tokio and tracing-subscriber feature arrays without semantic changes. Updated README examples to reflect new versions.
Example Files
examples/chat.rs, examples/chat_no_wait.rs, examples/e2e_test.rs, examples/full_config.rs, examples/secret_rotation.rs, examples/simple.rs, examples/without_mergers.rs
Consistently refactored secret key generation from SecretKey::generate(&mut rand::rng()) to parameterless SecretKey::generate() across all examples.
Internal Crypto Implementation
src/crypto/record.rs
Updated Record::encrypt to construct a SysRng-backed CSPRNG wrapper (UnwrapErr(SysRng)) and pass it to ed25519_dalek::SigningKey::generate instead of using rand::rng().
Test Files
src/gossip/topic/topic.rs, tests/tests.rs
Updated test setup code to call SecretKey::generate() without external RNG arguments in multiple test functions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 New versions hop into place,
Dependencies updated with grace,
Keys now generate on their own,
No RNG hand-holds are shown—
A cleaner, simpler codebase zone!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Iroh 98 update' accurately describes the primary change: updating the iroh dependency from 0.97 to 0.98 across Cargo.toml, README, and examples.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Cargo.toml`:
- Line 51: The getrandom dependency in Cargo.toml is missing the sys_rng feature
required to expose SysRng and the rand_core re-export used by
src/crypto/record.rs (SysRng and UnwrapErr); update the getrandom entry to
include "sys_rng" in its features (e.g., features = ["std", "sys_rng"]) while
keeping default-features = false so that SysRng and the rand_core items are
available to the code that imports SysRng/UnwrapErr.
- Around line 47-51: The rand dependency in Cargo.toml is missing the
"thread_rng" feature required by calls to rand::rng() (used in tests and
src/gossip/sender.rs); update the rand entry's features list to include
"thread_rng" so the crate builds with thread-local RNG support (i.e., add
"thread_rng" alongside "std" and "std_rng" in the rand = { ... features = [...]
} declaration).

In `@README.md`:
- Around line 14-22: Remove the unused rand dependency from the quick-start
Cargo snippet: delete the line containing "rand = \"0.9\"" so the example's
dependencies match the code (which no longer uses rand for key generation) and
avoid introducing a mismatched/unused direct dependency; update the dependency
list that includes anyhow, tokio, ed25519-dalek, iroh, iroh-gossip, and
distributed-topic-tracker accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0d492a2b-af05-438d-953f-35b14cd53414

📥 Commits

Reviewing files that changed from the base of the PR and between 5841c15 and 0c076a2.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (12)
  • Cargo.toml
  • README.md
  • examples/chat.rs
  • examples/chat_no_wait.rs
  • examples/e2e_test.rs
  • examples/full_config.rs
  • examples/secret_rotation.rs
  • examples/simple.rs
  • examples/without_mergers.rs
  • src/crypto/record.rs
  • src/gossip/topic/topic.rs
  • tests/tests.rs

Comment thread Cargo.toml Outdated
Comment thread Cargo.toml Outdated
Comment thread README.md
@rustonbsd rustonbsd merged commit 28a98ef into main Apr 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant