xen-store: handle short XenStore request writes - #18
Open
lkpdn wants to merge 1 commit into
Open
Conversation
4 tasks
xs_transaction() writes the request header with write_all(), then sends the payload with one writev(). A short write leaves XenStore waiting for the rest while the client waits for a reply. EINTR leaves the header stranded on the stream. Build each payload as one byte buffer and use write_all() for both parts. This retries short writes and EINTR, and removes the raw iovec handling and nix dependency. Add deterministic coverage for both cases. Fixes: 43a2751 ("Add support for Xen store API") Signed-off-by: Koichiro Den <den@valinux.co.jp>
Author
|
Sorry for the repeated force-pushes. I've just included the coverage update. PTAL, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
xs_transaction() writes the request header with write_all(), then sends the payload with one writev(). A short write leaves XenStore waiting for the rest while the client waits for a reply. EINTR leaves the header stranded on the stream.
Build each payload as one byte buffer and use write_all() for both parts. This retries short writes and EINTR, and removes the raw iovec handling and nix dependency.
Requirements
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.