Skip to content

Tell the user that nothing changed rather than a cryptic GitHub message#2446

Open
Urgau wants to merge 1 commit into
rust-lang:masterfrom
Urgau:gh-changes-since-no-changes
Open

Tell the user that nothing changed rather than a cryptic GitHub message#2446
Urgau wants to merge 1 commit into
rust-lang:masterfrom
Urgau:gh-changes-since-no-changes

Conversation

@Urgau

@Urgau Urgau commented Jun 24, 2026

Copy link
Copy Markdown
Member

Instead of redirecting the user to GitHub's compare view when nothing changed in our "View changes this review" link, show a clear message, instead of the cryptic GitHub message.

GitHub compare This PR
image image

cc @camelid

@Urgau Urgau requested a review from Kobzol June 24, 2026 17:09
Comment thread src/gh_changes_since.rs
Comment thread src/gh_changes_since.rs Outdated
@Urgau Urgau force-pushed the gh-changes-since-no-changes branch from fec0209 to 9268ba7 Compare June 26, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants