Block our expensive endpoints if our GitHub rate limits are too low#2445
Merged
Merged
Conversation
Mark-Simulacrum
approved these changes
Jun 24, 2026
c75092e to
f4e8e94
Compare
Member
Author
|
Yeah, using a second (or multiple) GitHub app(s) would fundamentally separate those issues, but has you said it would take some infra work. So for now, let's rate limit before GitHub rate limit us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up #triagebot > graphql rate-limit exhausted and #2443.
Let's block our exposed (and expensive) endpoints if our GitHub rate limits are too low (< 750 for either core or graphql), in order to keep our core functionalities (webhooks, github commands, ...) working.
Fetching GitHub
/rate_limit:(If we are worried about the secondary rate limits, we could try to cache the headers, but that's much more complicated.)
cc @Mark-Simulacrum