Add T-compiler P-high issues triage module#2431
Conversation
| use triagebot::actions::{Action, Query, QueryKind, QueryMap}; | ||
| use triagebot::github::issue_query::Query as IssueQuery; | ||
| use triagebot::github::{GithubClient, Repository}; | ||
| use triagebot::team_data::TeamClient; |
There was a problem hiding this comment.
So far, these are the dependencies on the triagebot. I'm thinking to move some code out of the triagebot that is used only for these binaries (triagebot::action::*) and pull the rest (triagebot::{github,team_data}) as a triagebot dependency.
team_data is a crate so easily detachable from the triagebot (right?). github ideally could become an external library.
Anyway, just thoughts for now.
| use std::collections::HashMap; | ||
| use std::sync::{Arc, LazyLock}; | ||
|
|
||
| use async_trait::async_trait; |
There was a problem hiding this comment.
Do we need this crate in 2026? I mean, don't we have something in stdlib?
There was a problem hiding this comment.
This is the only template I need here, I will cleanup the rest
There was a problem hiding this comment.
I'm surprised we still have the T-lang templates. We don't have the generators anymore, we should remove them.
I think that as long as the main code, that is I think we should got a step further and completely rip-out all the bits and pieces required used the agendas (for the github client, I would switch to the That way the agenda generators are completely independent, and we wouldn't even need workspaces. |
Thanks! I also think this is the way to go (see triagebot#2403). I'll keep on working on this path (as a workspace) to get a feel of the umbilical cord with the triagebot, then I'll see if I can cut it completely. |
apiraino
force-pushed
the
add-p-high-issues-triage-module
branch
13 times, most recently
from
7fe6ae4 to
f0fadf1
Compare
This comment has been minimized.
This comment has been minimized.
apiraino
force-pushed
the
add-p-high-issues-triage-module
branch
10 times, most recently
from
b514dca to
dca6240
Compare
apiraino
force-pushed
the
add-p-high-issues-triage-module
branch
3 times, most recently
from
fc4d97f to
36bc20f
Compare
apiraino
force-pushed
the
add-p-high-issues-triage-module
branch
from
36bc20f to
9e07145
Compare
|
@Urgau when you have time, I think we can start reviewing this. You mentioned that you wanted some redundant code removed: do you still see anything I can pull out (I left come of the basic functions in the client intact). Thanks |
3 participants
In an effort to make the triagebot more modular, I wanted to experiment with workspaces.
I need a new binary to run another meeting (the P-high issues review we do from time to time) and instead of adding code to the main triagebot codebase, I've tried creating a workspace ("utils", not a great name). Ideally I want to detach these binaries that now live under
./src/binand make them as independent as possible. Their main dependency i think is the GitHub client.Unsure if this is the right direction, so happy to get feedback!
r? @Urgau (for a first opinion, thanks!)