Integrate stdarch tests for aarch64#1667
Conversation
| "stdarch", | ||
| ); | ||
|
|
||
| static STDARCH: CargoProject = CargoProject::new(STDARCH_REPO.source_dir(), "stdarch_target"); |
There was a problem hiding this comment.
It should be possible to use the version from the standard library sources just like for portable-simd.
There was a problem hiding this comment.
Looks like the stdarch intrinsic-test crate gets stripped from the source before bundling: https://github.com/rust-lang/rust/blob/main/src/bootstrap/src/core/build_steps/dist.rs#L1204-L1208
There was a problem hiding this comment.
Right, I added those exclusions myself 🤦
There was a problem hiding this comment.
Turns out this is outdated anyways, the heavy intrinsics data now lives in library/stdarch/intrinsics_data, which isn't stripped. Also looks to be smaller than the 30MB it was in the past, around 12MB now, compresses to 300KB.
Would be simpler to remove the filter from upstream.
Yeah, I think that would work better. Aside from currently being a shorter list, it also avoids mistakenly thinking a new failing test got added that can be disabled just fine rather than an existing test now failing. |
2 participants
Had a go at wiring up
stdarch. Runs thecore_archandintrinsic-testtest suites.Looked into x86 as well. It had more hard errors to resolve up front, so opted to stick with aarch64 for now.
The skip mechanism for these may be a little cumbersome to maintain.
Maybe making the tests opt-in rather than opt-out would be the better approach?