Rollup of 17 pull requests - #161196
Open
JonathanBrouwer wants to merge 93 commits into
Open
Conversation
getsockname(2) and friends do not count the trailing NUL in the length they report on freebsd, netbsd and qnx, and a caller may bind(2) without one anywhere, so shortening the path by one byte dropped its last character. scan for the NUL within the reported length instead, which is the rule unix(7) gives and subsumes the qnx case the old cfg handled. Fixes rust-lang#118925
genmc: rename 'invalid' to 'moot'
This updates the rust-version file to 7dfb9d0.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@7dfb9d0 Filtered ref: rust-lang/miri@5cd9353 Upstream diff: rust-lang/rust@f73951d...7dfb9d0 This merge was created using https://github.com/rust-lang/josh-sync.
Automatic Rustup
This updates the rust-version file to 4667d75.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@4667d75 Filtered ref: rust-lang/miri@b4685b1 Upstream diff: rust-lang/rust@7dfb9d0...4667d75 This merge was created using https://github.com/rust-lang/josh-sync.
Automatic Rustup
When `for<'a>` appears on a closure without `closure_lifetime_binder`, suggest rewriting a simple let-bound closure to a stable `for<'a> fn(...)` binding type annotation when that rewrite is safe.
Cover MachineApplicable rewrites, MaybeIncorrect capture cases, and macro-expanded binders where structured suggestions must be suppressed.
…erver [Priroda] Add TCP DAP mode for VS Code attach
…he `retain` attribute
…fetime_binder_sugg, r=mejrs diagnostics: Suggest fn binding type for unstable closure for<> binders Fixes rust-lang#160431 `for<'a> |x: &'a T| -> U { ... }` currently just says "consider removing for<...>", which idk is kinda useless when someone landed there while fighting HRTB errors. This rewrites the obvious case to `let cl: for<'a> fn(...) = |x| { ... }` instead. Visitor emits the gate so we have AST context for the rewrite, and we still keep a pre-expansion fallback for `#[cfg(false)]` etc. MachineApplicable only when we're pretty sure: by-value bindings, lifetime-only unbounded binders, no `_` in the sig, no macro expansion. Capture checking is a conservative single-segment free-path heuristic since this runs pre-resolution/pre-typeck; when that looks uncertain we fall back to MaybeIncorrect (or just "consider removing"). imo that's the right tradeoff here: better a maybe-wrong help than rustfix auto-applying into E0308. fyi free-fn / `None` / `Some` cases also hit MaybeIncorrect for the same reason. ltm if the heuristic feels too conservative and y'all want it tightened later.
Add regression test for borrow of array drop type in const Closes rust-lang#86672
Add regression test for path printing with infinitely many visible names Closes rust-lang#57500
Add regression test for unstable def_ident_span fingerprint with incremental recompilation Closes rust-lang#95945
…1999 cleanup: rip out unnecessary `iter().last()` and `iter().next()` Continuation of rust-lang#145402
…=folkertdev Add BPF test for Rust ABI stack arguments
Switch to c8a EC2 runner for auto merges I *think* this is the only line that needs changing to switch? I expect we'll want to clean up the codebuild stuff, but I think it makes sense to leave it in place until this has merged successfully and run for a few weeks. r? Kobzol
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
…ack, r=Urgau Add back flaky gui rustdoc test `tests/rustdoc-gui/headers-color.goml` Part of rust-lang#152197. This PR adds back `tests/rustdoc-gui/headers-color.goml` with a little tweak: instead of using `go-to` command to change the focused element, we click on the anchors. r? @Urgau
Contributor
Author
|
@bors r+ p=5 |
Contributor
Contributor
|
⌛ Testing commit 9692358 with merge 2c39ff4... Workflow: https://github.com/rust-lang/rust/actions/runs/31974949705 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 16, 2026
…uwer Rollup of 17 pull requests Successful merges: - #161017 (Library: enforce clippy deref lints in CI) - #160416 (std: fix unix socket address truncation without a trailing NUL) - #161006 ([CI] Build newer `binutils` before building `gcc`) - #161141 (Add documentation for BPF targets) - #161157 (bootstrap: Move several items out of the crate root) - #161185 (std: guard against unwinds in queue-based `Once`) - #161186 (miri subtree update) - #159855 (std: retry waitid on EINTR in the pidfd wait path) - #160478 (diagnostics: Suggest fn binding type for unstable closure for<> binders) - #161053 (Add regression test for borrow of array drop type in const) - #161073 (Add regression test for path printing with infinitely many visible names) - #161099 (Add regression test for unstable def_ident_span fingerprint with incremental recompilation) - #161103 (cleanup: rip out unnecessary `iter().last()` and `iter().next()`) - #161136 (Add BPF test for Rust ABI stack arguments) - #161146 (Switch to c8a EC2 runner for auto merges) - #161148 ([rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore)) - #161181 (Add back flaky gui rustdoc test `tests/rustdoc-gui/headers-color.goml`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
binutilsbefore buildinggcc#161006 ([CI] Build newerbinutilsbefore buildinggcc)Once#161185 (std: guard against unwinds in queue-basedOnce)iter().last()anditer().next()#161103 (cleanup: rip out unnecessaryiter().last()anditer().next())tests/rustdoc-gui/headers-color.goml#161181 (Add back flaky gui rustdoc testtests/rustdoc-gui/headers-color.goml)r? @ghost
Create a similar rollup