Skip to content

try to bump profiler_builtins dependency on cc - #161165

Open
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:profiler-builtins
Open

try to bump profiler_builtins dependency on cc#161165
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:profiler-builtins

Conversation

@RalfJung

@RalfJung RalfJung commented Aug 16, 2026

Copy link
Copy Markdown
Member

View all comments

This got pinned so it doesn't get auto-updated, and apparently nobody is in charge of manually updating it. 1.2.62 isn't the latest version but it has been used by rustc for a while so it seems to be a good version.

Cc @jieyouxu @bjorn3

@rustbot

rustbot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2026
@rustbot

rustbot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

@RalfJung

Copy link
Copy Markdown
Member Author

@bors try jobs=dist*,aarch64

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 16, 2026
try to bump profiler_builtins dependency on cc


try-job: dist*
try-job: *aarch64*
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2026
@rust-bors

rust-bors Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

💔 Test for e531de0 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@RalfJung

Copy link
Copy Markdown
Member Author

@bors try jobs=msvc,aarch64

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 16, 2026
try to bump profiler_builtins dependency on cc


try-job: *msvc*
try-job: *aarch64*
@rust-bors

rust-bors Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

💔 Test for e7e0bb8 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@RalfJung

Copy link
Copy Markdown
Member Author

sigh quite hard to run meaningful tests here, it always says "too many jobs"...

@bors try jobs=msvc

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 16, 2026
try to bump profiler_builtins dependency on cc


try-job: *msvc*
@rust-log-analyzer

This comment has been minimized.

@rustbot

rustbot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @BoxyUwU

@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 16, 2026
@RalfJung

Copy link
Copy Markdown
Member Author

Cc @NobodyXu @madsmtm for this "new" dependency of cc. Seems to be a rust-lang org crate so I hope it's fine to add it to the allowlist.

@rust-log-analyzer

This comment was marked as resolved.

@RalfJung

Copy link
Copy Markdown
Member Author

@bors try jobs=msvc

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 16, 2026
try to bump profiler_builtins dependency on cc


try-job: *msvc*
@madsmtm

madsmtm commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Yes, find-msvc-tools is maintained as part of cc-rs

@rust-bors

rust-bors Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 6d930da (6d930da6e1e89e22b15512ddd24158cda7aa9293)
Base parent: 67854e5 (67854e511de21d881bb16426996cd4259d44aa2e)

@RalfJung

Copy link
Copy Markdown
Member Author

@bors try jobs=aarch64

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 16, 2026
try to bump profiler_builtins dependency on cc


try-job: *aarch64*
@rust-bors

rust-bors Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: ed313aa (ed313aa65393969c21dae47aeab647c3e376a732)
Base parent: 874e6f2 (874e6f2a533b28b77892709ba774614a96686840)

@RalfJung

Copy link
Copy Markdown
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants