Make ShardedHashMap::with_capacity split capacity between shards - #161127
Open
Zoxc wants to merge 1 commit into
Open
Make ShardedHashMap::with_capacity split capacity between shards#161127Zoxc wants to merge 1 commit into
Zoxc wants to merge 1 commit into
Conversation
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
With
|
|||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
nnethercote
approved these changes
Aug 15, 2026
Contributor
|
Oh dear. Let's see if this affects any of the parallel benchmarks on CI. @bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
Contributor
|
⌛ Trying commit 76c314f with merge 346a635… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/31881292297 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 15, 2026
Make ShardedHashMap::with_capacity split capacity between shards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
ShardedHashMap::with_capacitysplit capacity between shards. The callers inCtxtInterners::newdid not divide these by the shard count, so it reserved 32 times greater capacity, significantly contributing to startup costs.Spotted by Claude Opus while investigating startup stack usage.