Skip to content

Perf: Clear the param env for more global trait goals #161126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dandandan wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

Perf: Clear the param env for more global trait goals #161126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions compiler/rustc_trait_selection/src/traits/select/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,8 +1009,14 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> {
mut obligation: PolyTraitObligation<'tcx>,
) -> Result<EvaluationResult, OverflowError> {
if !self.typing_mode().is_coherence()
&& obligation.is_global()
&& obligation.param_env.caller_bounds().iter().all(|bound| bound.has_param())
&& obligation.predicate.is_global()
&& obligation.param_env.caller_bounds().iter().all(|bound| {
bound.has_param()
|| matches!(
bound.kind().skip_binder(),
ty::ClauseKind::RegionOutlives(_) | ty::ClauseKind::TypeOutlives(_)
)
})
{
// If a param env has no global bounds, global obligations do not
// depend on its particular value in order to work, so we can clear
Expand Down
Loading