Rollup of 6 pull requests - #161113
Merged
Merged
Conversation
Signed-off-by: 林晨 (Leo Cheng) <leo-cheng@vip.qq.com>
Signed-off-by: HNO3Miracle <xiangao.or@isrc.iscas.ac.cn>
This reverts commit 78f7e79.
…ator, r=jhpratt,dtolnay core: implement FusedIterator for StepBy Implements the accepted ACP rust-lang/libs-team#757. `StepBy` yields no more items once its underlying iterator is exhausted, so it is fused whenever the underlying iterator is fused. `StepBy` was added in 1.28.0, just after the batch of `FusedIterator` impls stabilized in 1.26.0 (`Map`, `Skip`, `Take`, `Enumerate`, ...), so it was left out. ```rust impl<I: FusedIterator> FusedIterator for StepBy<I> {} ``` This is insta-stable, matching the sibling adapter impls, so it needs a libs-api FCP. Motivation from the ACP: crates with traits refined on top of `FusedIterator` (e.g. `range-set-blaze`'s `SortedStarts`) cannot cover `StepBy` today, even though it would always be valid. A `test_step_by_fused` regression test is added.
…ions, r=traviscross tests/ui/union: add annotations for reference rules r? lang-docs
…=clubby789 cargotest: replace Servo with standalone Stylo The Servo entry in `cargotest` pins a 2019 checkout and only tests the `selectors` package. Cargo still has to resolve the old Servo workspace, including its large graph of Git dependencies, even though most of that workspace is not covered by the test. Both `selectors` and the `stylo` CSS engine now live in the standalone [`servo/stylo`](https://github.com/servo/stylo) repository. This PR replaces the old Servo checkout with a recent Stylo revision and runs both `cargo test -p selectors` and `cargo test -p stylo` from the same checkout. Stylo's unit tests previously failed under the default Servo configuration because shared tests used pseudo-elements that were only available in Gecko. This was fixed in [`servo/stylo#436`](servo/stylo#436), and this PR pins the resulting revision. The `cargotest` documentation is updated to list Stylo instead of Servo. Tests: - `cargo test --manifest-path src/tools/cargotest/Cargo.toml` - `target/debug/cargotest "$(command -v cargo)" /tmp/cargotest-stylo stylo` - `./x test tidy --set build.submodules=false` Closes rust-lang#79404.
…st-2018, r=traviscross tests/ui/rust-2018: add annotations for reference rules
…anBrouwer Revert "Add regression test for const fn returning Vec of boxed dyn Any" Reverts rust-lang#161010 as requested, it was a feature stabilized not a bug r? @chenyukang
rustc.1: `-O` is `-C opt-level=3` This was changed back in 1.86, rust-lang#135439.
rustbot
added
A-rustc-dev-guide
Contributor
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: d453bdd8f0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: d453bdd8f0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d453bdd (parent) -> 68c677a (this PR) Test differencesShow 7 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 68c677ac3f013d2e587f47e198c92e551716191e --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (68c677a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -6.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 8.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 461.184s -> 459.748s (-0.31%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Ois-C opt-level=3#161112 (rustc.1:-Ois-C opt-level=3)r? @ghost
Create a similar rollup