rustdoc: Small doc_cfg messages improvements - #161105
Merged
rust-bors[bot] merged 3 commits intoAug 15, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Urgau
reviewed
Aug 14, 2026
| CfgEntry::Any(a, _) | CfgEntry::All(a, _) => { | ||
| a.is_empty() || matches!(a.as_slice(), [a] if omit_preposition(&a)) | ||
| } | ||
| CfgEntry::Not(a, _) => omit_preposition(a), |
Member
There was a problem hiding this comment.
Could you add a test for this Not branch.
| true | ||
| } | ||
| } | ||
| CfgEntry::Not(a, _) => !should_append_only_to_description(a), |
Member
There was a problem hiding this comment.
Same for here.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
improve-cfg-message
branch
from
August 14, 2026 21:18
d1f02d6 to
97fdee6
Compare
Collaborator
|
Member
Author
|
At some point, I'll implement the full "cleanup" to replace cases like |
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 15, 2026
…, r=Urgau rustdoc: Small `doc_cfg` messages improvements Fixes rust-lang#145075. I was writing a regression test for rust-lang#145075 which was already fixed, saw it was looking like this: <img width="242" height="247" alt="image" src="https://github.com/user-attachments/assets/421e6b4b-698f-4a01-93d9-022eb346d73c" /> So I made some small changes to improve the wording. Now it looks like this: <img width="242" height="247" alt="image" src="https://github.com/user-attachments/assets/c950dd68-a760-4f18-b974-555e05fcfd78" /> r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 15, 2026
…, r=Urgau rustdoc: Small `doc_cfg` messages improvements Fixes rust-lang#145075. I was writing a regression test for rust-lang#145075 which was already fixed, saw it was looking like this: <img width="242" height="247" alt="image" src="https://github.com/user-attachments/assets/421e6b4b-698f-4a01-93d9-022eb346d73c" /> So I made some small changes to improve the wording. Now it looks like this: <img width="242" height="247" alt="image" src="https://github.com/user-attachments/assets/c950dd68-a760-4f18-b974-555e05fcfd78" /> r? @Urgau
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 15, 2026
…uwer Rollup of 5 pull requests Successful merges: - #161111 (Take bors try-perf branch into account in verify-channel.sh) - #158504 (Stabilize `extern "custom"`) - #161030 (mailmap: fix nia's gazillion emails) - #161105 (rustdoc: Small `doc_cfg` messages improvements) - #161123 (bootstrap: Clean up some inconsistent imports and paths)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 15, 2026
Rollup merge of #161105 - GuillaumeGomez:improve-cfg-message, r=Urgau rustdoc: Small `doc_cfg` messages improvements Fixes #145075. I was writing a regression test for #145075 which was already fixed, saw it was looking like this: <img width="242" height="247" alt="image" src="https://github.com/user-attachments/assets/421e6b4b-698f-4a01-93d9-022eb346d73c" /> So I made some small changes to improve the wording. Now it looks like this: <img width="242" height="247" alt="image" src="https://github.com/user-attachments/assets/c950dd68-a760-4f18-b974-555e05fcfd78" /> r? @Urgau
rust-timer
added a commit
that referenced
this pull request
Aug 15, 2026
Rollup merge of #161105 - GuillaumeGomez:improve-cfg-message, r=Urgau rustdoc: Small `doc_cfg` messages improvements Fixes #145075. I was writing a regression test for #145075 which was already fixed, saw it was looking like this: <img width="242" height="247" alt="image" src="https://github.com/user-attachments/assets/421e6b4b-698f-4a01-93d9-022eb346d73c" /> So I made some small changes to improve the wording. Now it looks like this: <img width="242" height="247" alt="image" src="https://github.com/user-attachments/assets/c950dd68-a760-4f18-b974-555e05fcfd78" /> r? @Urgau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145075.
I was writing a regression test for #145075 which was already fixed, saw it was looking like this:
So I made some small changes to improve the wording. Now it looks like this:
r? @Urgau