Move attribute and keyword docs from std to core#158327
Conversation
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
Thanks! @bors r+ rollup |
…-keywords-to-core, r=GuillaumeGomez Move attribute and keyword docs from `std` to `core` Move the documentation for attributes and keywords into the `core` crate. Apart from strictly moving the module, I had to make a few small changes to certain docs to avoid using `std` types when possible, as well as fixing a few suggestions related to linking to primitives. Pre-requisite for work on rust-lang#157604. r? @GuillaumeGomez Verified documentation using: `./x doc library/core` and `./x doc library/std`, as well as running doc-tests for both crates.
…-keywords-to-core, r=GuillaumeGomez Move attribute and keyword docs from `std` to `core` Move the documentation for attributes and keywords into the `core` crate. Apart from strictly moving the module, I had to make a few small changes to certain docs to avoid using `std` types when possible, as well as fixing a few suggestions related to linking to primitives. Pre-requisite for work on rust-lang#157604. r? @GuillaumeGomez Verified documentation using: `./x doc library/core` and `./x doc library/std`, as well as running doc-tests for both crates.
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #158389 (comment) |
|
This pull request was unapproved. This PR was contained in a rollup (#158389), which was unapproved. |
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
2ce02ed to
8230837
Compare
|
@bors try job=test-various |
This comment has been minimized.
This comment has been minimized.
…o-core, r=<try> Move attribute and keyword docs from `std` to `core` try-job: test-various
|
💔 Test for 6850d53 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
|
@bors try job=test-various |
|
@jschillem: 🔑 Insufficient privileges: not in try users |
|
@GuillaumeGomez it seems the doc tests are failing for WASM due to the |
https://doc.rust-lang.org/rustc/platform-support/wasm32-wasip1.html#testing |
|
@rustbot review |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Move the documentation for attributes and keywords into the
corecrate. Apart from strictly moving the module, I had to make a few small changes to certain docs to avoid usingstdtypes when possible, as well as fixing a few suggestions related to linking to primitives.Pre-requisite for work on #157604.
r? @GuillaumeGomez
Verified documentation using:
./x doc library/coreand./x doc library/std, as well as running doc-tests for both crates.