hermit/fs: Return unsupported() instead of from_raw_os_error(22)#158247
Open
mkroening wants to merge 1 commit into
Open
hermit/fs: Return unsupported() instead of from_raw_os_error(22)#158247mkroening wants to merge 1 commit into
unsupported() instead of from_raw_os_error(22)#158247mkroening wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
The CI failure is spurious and caused by GitHub. I will force-push to rerun CI. |
mkroening
force-pushed
the
hermit-fs-unsupported
branch
from
5177331 to
d54558f
Compare
Contributor
rustbot
added
S-blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Hermit uses a mix of
Err(Error::from_raw_os_error(22))(EINVAL) andunsupported()for unsupported operations.This PR makes Hermit consistently use
unsupported()everywhere. This should address #158168 (comment) and #158168 (comment).r? clarfonthey
CC: @stlankes