Rollup of 4 pull requests#158212
Merged
Merged
Conversation
This also syncs `RUSTFLAGS: -D warnings` which is added in rust-lang/rustfmt
This is an optimization to reduce the amount for paths that get added to the dylib search path. This is especially important for Windows as it has issues when PATH gets too long. With the new Cargo build-dir we increased the number of paths being passed.
This allows compiletest to support the new Cargo `build-dir` layout which passes more `-L` flags as the `deps` dir has been split per build unit. This can be an issue on Windows as the max command size is fairly small.
This reduces the size of PATH on windows during macro expansion to avoid hitting windows limits. With the new Cargo build-dir layout this becomes more important as Cargo now passes more `-L` args which end up bloating PATH.
…yout, r=bjorn3,kobzol Enable Cargo's new build-dir layout This PR enables the new Cargo `build-dir` layout in boostrap builds with `-Zbuild-dir-new-layout`. See: [#t-infra/bootstrap > Has anyone tested &rust-lang#96;./x&rust-lang#96; with the new build-dir layout?](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Has.20anyone.20tested.20.60.2E.2Fx.60.20with.20the.20new.20build-dir.20layout.3F/with/581660716) Tracked in: rust-lang/cargo#15010 r? @bjorn3 cc: @epage
…op-order-awaitee, r=JonathanBrouwer Do not use desugared local names in tail_expr_drop_order diagnostics `tail_expr_drop_order` labels values using names from `body.var_debug_info`. That works for user-written bindings, but `.await` lowering also introduces a synthetic `__awaitee` binding for debuginfo. This can leak into the user-facing lint diagnostic. This PR filters collected diagnostic names through `LocalDecl::from_compiler_desugaring()`, so compiler-generated locals fall back to the existing `#N` temporary labels. This does not change async lowering or the `__awaitee` debuginfo name itself. A user-written binding named `__awaitee` is still treated as user-written and is still shown by name. Fixes rust-lang#136206
…nt, r=jdonszelmann Remove `has_delayed_lints` optimization Keeping track of `has_delayed_lints` doesn't seem to have a perf effect anymore so let's not make the code more complicated than needed. These flags were previously used so we don't have to iterate over all hir owners, but iterating over all hir owners seems fast enough cc @jdonszelmann
More general assert in Interner const fn check Fixes rust-lang#158188
rustbot
added
A-CI
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 40f92b37c4 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 40f92b3 (parent) -> ff64732 (this PR) Test differencesShow 10 test diffsStage 1
Stage 2
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ff647322379c48947c196639599067665ff9eb88 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Jun 21, 2026
Collaborator
|
Finished benchmarking commit (ff64732): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -2.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.2%, secondary 3.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 479.892s -> 482.919s (0.63%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
has_delayed_lintsoptimization #158193 (Removehas_delayed_lintsoptimization)r? @ghost
Create a similar rollup