Skip to content

Fixed split_maybe_args to split on default shell IFS (space, tab, ne…#155066

Closed
Sandijigs wants to merge 3 commits into
rust-lang:mainfrom
Sandijigs:fix/shell-whitespace-splitting-132599
Closed

Fixed split_maybe_args to split on default shell IFS (space, tab, ne…#155066
Sandijigs wants to merge 3 commits into
rust-lang:mainfrom
Sandijigs:fix/shell-whitespace-splitting-132599

Conversation

@Sandijigs

@Sandijigs Sandijigs commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

This PR fixes the split_maybe_args function in run-make-support to correctly split
on default shell IFS characters (space, tab, newline), instead of only splitting
on spaces.

Relates to implement shell whitespace splitting correctly

@rustbot

rustbot commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

The run-make-support library was changed

cc @jieyouxu

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026
@rustbot

rustbot commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot

rustbot commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @jieyouxu

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@jieyouxu

Copy link
Copy Markdown
Member

Thanks for the PR. However, I am going to close this PR in favor of an earlier PR (#154479) when the PR author already claimed the issue.

@jieyouxu jieyouxu closed this Apr 10, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2026
@jieyouxu

Copy link
Copy Markdown
Member

Also, please do not submit PR descriptions generated via LLMs.

@Sandijigs

Copy link
Copy Markdown
Contributor Author

Thanks for the PR. However, I am going to close this PR in favor of an earlier PR (#154479) when the PR author already claimed the issue.

oh , okay , I made this PR in reference to the outreachy issue :implement shell whitespace splitting correctly

@Sandijigs Sandijigs deleted the fix/shell-whitespace-splitting-132599 branch April 10, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants