Skip to content

as_simd: fix doc comment to be in line with align_to#127422

Merged
bors merged 1 commit into
rust-lang:masterfrom
greaka:master
Jul 12, 2024
Merged

as_simd: fix doc comment to be in line with align_to#127422
bors merged 1 commit into
rust-lang:masterfrom
greaka:master

Conversation

@greaka

@greaka greaka commented Jul 6, 2024

Copy link
Copy Markdown
Contributor

In #121201, the guarantees about align_offset and align_to were changed. This PR aims to correct the doc comment of as_simd to be in line with the new align_to.

Tagging #86656 for good measure.

@rustbot

rustbot commented Jul 6, 2024

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @workingjubilee (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 6, 2024

@workingjubilee workingjubilee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run cargo fmt or something instead of ./x.py fmt? In any case, please back out the formatting changes to unrelated code so I can approve this.

Comment thread library/core/src/slice/iter.rs Outdated
Comment thread library/core/src/slice/iter.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2024
@greaka

greaka commented Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

That'd explain it, thanks!

@greaka

greaka commented Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 11, 2024
@workingjubilee

Copy link
Copy Markdown
Member

Great! @bors r+ rollup

@bors

bors commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 585ca16 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2024
@bors bors merged commit 1e7ad4c into rust-lang:master Jul 12, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants