Avoid bounded backtracker when max haystack length is zero - #1384
Open
fyrsta7 wants to merge 1 commit into
Open
Conversation
fyrsta7
marked this pull request as ready for review
August 8, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1344 by avoiding the bounded backtracker in the meta engine when its computed maximum haystack length is zero.
Details
The meta wrapper already skips the bounded backtracker when the input span is longer than
max_haystack_len(). When the maximum saturates to zero, an empty input span is not greater than the maximum, so the wrapper still selected the backtracker. The backtracker then returnedHaystackTooLong { len: 0 }, which the wrapper unwrapped.This treats a zero maximum as meaning the backtracker should not be used for that regex and lets the meta engine fall through to the next strategy.
Validation
git diff --checkcargo fmt --all --checkcargo test -p regex-automata backtracker_zero_max_haystack_len --test integration --features meta -- --nocapturecargo test -p regex-automata --features meta,nfa-backtrack