regex-cli: validate patterns before combining alternations#1367
Open
ayakamiki wants to merge 1 commit into
Open
regex-cli: validate patterns before combining alternations#1367ayakamiki wants to merge 1 commit into
ayakamiki wants to merge 1 commit into
Conversation
Fix a regex-cli bug where --combine-patterns could accept individually invalid patterns if joining them with | happened to produce a valid regex. Make args::patterns::Config::get syntax-aware by validating each pattern with the current CLI syntax configuration before combining. This preserves support for syntax-dependent options such as --octal while rejecting misleading inputs earlier. Also update regex-cli call sites to pass syntax config through and add focused tests for rejecting individually invalid patterns, accepting individually valid patterns, and respecting syntax configuration during validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a regex-cli bug where --combine-patterns could accept individually invalid patterns if joining them with | happened to produce a valid regex.
Make args::patterns::Config::get syntax-aware by validating each pattern with the current CLI syntax configuration before combining. This preserves support for syntax-dependent options such as --octal while rejecting misleading inputs earlier.
Also update regex-cli call sites to pass syntax config through and add focused tests for rejecting individually invalid patterns, accepting individually valid patterns, and respecting syntax configuration during validation.