Add library to mdbook crate#3071
Conversation
|
Admittedly this change is quite weird but do want to find a conclusion to #2954 For reviewers, |
|
re: https://github.com/rust-lang/mdBook/actions/runs/24518893029/job/71670723888?pr=3071 This seems to build locally but I wonder if there's confusion in the lack of a library in the previous release |
This comment has been minimized.
This comment has been minimized.
|
@ehuss friendly ping 🙏 |
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@ehuss friendly ping here. In response to #3071 (comment) I did some deep diving into the workflow and found that binary-only crates are skipped and the issue I was seeing comes from the transition of binary-only to lib crate. I think it'd be fine to maintain the previous behavior at least until the next release. |
This change adds a library to the
mdbookcrate so the entrypoint can be consumed without the need for a nightly toolchain to be able to use-Z bindeps(rust-lang/cargo#9096)closes #2954