Skip to content

add CI for armv7-unknown-linux-uclibceabihf#2640

Merged
bors merged 1 commit into
rust-lang:masterfrom
skrap:master
Jan 21, 2022
Merged

add CI for armv7-unknown-linux-uclibceabihf#2640
bors merged 1 commit into
rust-lang:masterfrom
skrap:master

Conversation

@skrap

@skrap skrap commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

As discussed in #2636, this is a framework for CI on targets with no prebuilt std. They will build via nightly and -Zbuild-std, and run the unit tests via qemu-user (or whatever else the dockerfile specifies).

It seems like I could write some more documentation about how to add more targets of this type, but perhaps I can get a round of feedback on the mechanism here before I go and write that.

@rust-highfive

Copy link
Copy Markdown

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@skrap

skrap commented Jan 21, 2022

Copy link
Copy Markdown
Contributor Author

I don't know that I agree with shellcheck's warning here. I want to split EXTRA_CARGO_ARGS on spaces. shellcheck's docs call out this valid use case, but their sh-compatible workaround is to put the whole call in a function and use $@, which feels like a pretty big change (and IMO pretty ugly). Instead I'll just make the solution less general and not try to build a general extra args feature.

@Amanieu

Amanieu commented Jan 21, 2022

Copy link
Copy Markdown
Member

LGTM!

@bors r+

@bors

bors commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

📌 Commit d93b11d has been approved by Amanieu

@bors

bors commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit d93b11d with merge 804cef7...

bors added a commit that referenced this pull request Jan 21, 2022
add CI for armv7-unknown-linux-uclibceabihf

As discussed in #2636, this is a framework for CI on targets with no prebuilt std.  They will build via `nightly` and `-Zbuild-std`, and run the unit tests via qemu-user (or whatever else the dockerfile specifies).

It seems like I could write some more documentation about how to add more targets of this type, but perhaps I can get a round of feedback on the mechanism here before I go and write that.
@skrap

skrap commented Jan 21, 2022

Copy link
Copy Markdown
Contributor Author

Great! Once this is merged, feel free to @mention me on any CI failures involving uclibc. I'll be happy to help them get resolved.

@bors

bors commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-actions

@Amanieu

Amanieu commented Jan 21, 2022

Copy link
Copy Markdown
Member

CI is also spewing a bunch of errors along the lines "/toolchain/relocate-sdk.sh: 39: file: not found".

@skrap

skrap commented Jan 21, 2022

Copy link
Copy Markdown
Contributor Author

CI is also spewing a bunch of errors along the lines "/toolchain/relocate-sdk.sh: 39: file: not found".

Yeah, I just pushed a fix for that, thanks for the heads up.

@Amanieu

Amanieu commented Jan 21, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

📌 Commit bc9e590 has been approved by Amanieu

@skrap

skrap commented Jan 21, 2022

Copy link
Copy Markdown
Contributor Author

Huh, I don't think bors ran anything for that commit. Did I break it somehow??

@Amanieu

Amanieu commented Jan 21, 2022

Copy link
Copy Markdown
Member

@bors retry

@Amanieu

Amanieu commented Jan 21, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

📌 Commit bc9e590 has been approved by Amanieu

@Amanieu

Amanieu commented Jan 21, 2022

Copy link
Copy Markdown
Member

There seems to have been some issue with the macOS runners in CI. I restarted the jobs and it seems to be working now.

@bors

bors commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit bc9e590 with merge 8bba79c...

@bors

bors commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 8bba79c to master...

@bors bors merged commit 8bba79c into rust-lang:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants