Skip to content

Skip 4 crates with broken beta version parsing#817

Merged
Mark-Simulacrum merged 1 commit into
rust-lang:masterfrom
theemathas:patch-2
Jun 17, 2026
Merged

Skip 4 crates with broken beta version parsing#817
Mark-Simulacrum merged 1 commit into
rust-lang:masterfrom
theemathas:patch-2

Conversation

@theemathas

Copy link
Copy Markdown
Contributor

Discovered in rust-lang/rust#149833

@Skgland

Skgland commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

At least some of these (all but forkable appear to just be graphicmagic-sys) are using rust-bindgen to parse the version the issue rust-lang/rust-bindgen#3152 was recently fixed and it should just need a dependency update to fix the crates that are using it.
So maybe it would make sense to hold of on adding them. (While adding crates is easy, removing them isn't and I am not aware of crates ever being rechecked and removed from the list.)

@theemathas

Copy link
Copy Markdown
Contributor Author

All four of these crates still have broken beta version parsing. See https://crater-reports.s3.amazonaws.com/beta-1.96-2/index.html

Should this PR be merged, then?

@jieyouxu

Copy link
Copy Markdown
Member

Let's merge this for now, if someone is willing to do the work of reassessing later, more than happy to review / undo

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu jieyouxu enabled auto-merge April 29, 2026 04:47
@jieyouxu jieyouxu disabled auto-merge April 29, 2026 04:47
@jieyouxu

This comment was marked as outdated.

@jieyouxu

Copy link
Copy Markdown
Member

(I forgot I can push, rebased)

@jieyouxu jieyouxu enabled auto-merge April 29, 2026 04:54
auto-merge was automatically disabled April 29, 2026 04:57

Head branch was pushed to by a user without write access

@theemathas

Copy link
Copy Markdown
Contributor Author

I also just force-pushed a rebase because I didn't see your latest comment. Not sure if I messed up anything 😅

@jieyouxu

Copy link
Copy Markdown
Member

Nah it's fine, it wasn't queued yet

@jieyouxu jieyouxu enabled auto-merge April 29, 2026 04:59
@jieyouxu jieyouxu added this pull request to the merge queue Apr 29, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 29, 2026
@theemathas

Copy link
Copy Markdown
Contributor Author

... what happened?

@jieyouxu jieyouxu added this pull request to the merge queue Apr 29, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 29, 2026
@theemathas

Copy link
Copy Markdown
Contributor Author

There's a test failure? Is this spurious?

@jieyouxu

Copy link
Copy Markdown
Member
failures:
    minicrater::multi_thread_full
    minicrater::single_thread_full

Not sure

@Skgland

Skgland commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Looks like the error code returned by the beta compiler no longer matches the expectation. This should be a non-spurious error caused by beta changing over time.

https://github.com/rust-lang/crater/actions/runs/25092719910/job/73522306965#step:4:10129

@theemathas

Copy link
Copy Markdown
Contributor Author

Can this be merged now, given that #835 has been merged?

@Mark-Simulacrum Mark-Simulacrum added this pull request to the merge queue Jun 17, 2026
Merged via the queue into rust-lang:master with commit 637f5fb Jun 17, 2026
3 checks passed
@theemathas theemathas deleted the patch-2 branch June 18, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants