Skip to content

Don't separate files/opt when using msvc assembler#747

Merged
thomcc merged 1 commit into
rust-lang:mainfrom
roblabla:msvc-dont-pass-dash-dash-asm
Nov 8, 2022
Merged

Don't separate files/opt when using msvc assembler#747
thomcc merged 1 commit into
rust-lang:mainfrom
roblabla:msvc-dont-pass-dash-dash-asm

Conversation

@roblabla

@roblabla roblabla commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

The MSVC assemblers don't support using -- to mark the end of the options and the start of the "verbatim" file list. When the compiler family is MSVC with clang-cl, the assembler used will be the standard MSVC assembler.

See rust-lang/rust#104152 (comment)

The MSVC assemblers don't support using `--` to mark the end of the
options and the start of the "verbatim" file list. When the compiler
family is MSVC with clang-cl, the assembler used will be the standard
MSVC assembler.

@thomcc thomcc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@thomcc thomcc merged commit 0e5b395 into rust-lang:main Nov 8, 2022
@thomcc

thomcc commented Nov 8, 2022

Copy link
Copy Markdown
Member

If this fixes rust-lang/rust I'll try to get a hotfix release out later today or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants