Skip to content

[beta] Add period to allowed feature name characters.#8943

Merged
bors merged 2 commits into
rust-lang:rust-1.49.0from
ehuss:beta-features-with-dot
Dec 5, 2020
Merged

[beta] Add period to allowed feature name characters.#8943
bors merged 2 commits into
rust-lang:rust-1.49.0from
ehuss:beta-features-with-dot

Conversation

@ehuss

@ehuss ehuss commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

Beta backport of #8932.

@rust-highfive

Copy link
Copy Markdown

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive

Copy link
Copy Markdown

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.49.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2020
Fix semver documentation tests.

GitHub just updated the VM image to include the latest stable rust (1.48), which included some minor changes to diagnostic outputs.  This updates the semver chapter tests which validates that the correct error is displayed for the 1.48 release.  These diagnostics were changed via rust-lang/rust#76524 and rust-lang/rust#73996.
@ehuss

ehuss commented Dec 4, 2020

Copy link
Copy Markdown
Contributor Author

Also added #8930 to get CI to pass.

@Eh2406

Eh2406 commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

📌 Commit 7bd820d has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2020
@bors

bors commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

⌛ Testing commit 7bd820d with merge d00d64d...

@bors

bors commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: Eh2406
Pushing d00d64d to rust-1.49.0...

@bors bors merged commit d00d64d into rust-lang:rust-1.49.0 Dec 5, 2020
@ehuss ehuss added this to the 1.49.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants