chore(listings): remove orphan ch21 listings and renumber final-code (#4644)#4787
Open
Dodothereal wants to merge 1 commit into
Open
chore(listings): remove orphan ch21 listings and renumber final-code (#4644)#4787Dodothereal wants to merge 1 commit into
Dodothereal wants to merge 1 commit into
Conversation
…ust-lang#4644) The two no-listing-05-fix-worker-new and no-listing-06-fix-threadpool-drop directories under listings/ch21-web-server/ are not referenced from src/ch21-03-graceful-shutdown-and-cleanup.md anymore (the chapter only embeds 21-22 .. 21-25, no-listing-04-update-drop-definition and no-listing-07-final-code from the no-listing series); they predate the recent tech-review revisions and carry outdated Worker::new / Drop impl content. This commit: - Deletes the two unreferenced listing trees outright. - Renames the still-used no-listing-07-final-code to no-listing-05-final-code so the remaining no-listing series stays contiguous (01..02..03..04..05). - Updates the two rustdoc_include references in src/ch21-03-graceful-shutdown-and-cleanup.md accordingly. Closes rust-lang#4644
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4644
Summary
The two listings
no-listing-05-fix-worker-newandno-listing-06-fix-threadpool-dropunderlistings/ch21-web-server/are no longer referenced from
src/ch21-03-graceful-shutdown-and-cleanup.mdand predate the recent tech-review revisions — they carry outdated
Worker::newandDropimpl content.This PR:
listings/ch21-web-server/no-listing-05-fix-worker-new/.listings/ch21-web-server/no-listing-06-fix-threadpool-drop/.listings/ch21-web-server/no-listing-07-final-code/tolistings/ch21-web-server/no-listing-05-final-code/so theremaining no-listing series stays contiguous (01..02..03..04..05).
rustdoc_includereferences insrc/ch21-03-graceful-shutdown-and-cleanup.mdto the new path.The chapter text itself is unchanged. Only listing book-keeping is
touched.
Test plan
mdbook buildshould recompile the chapter without warnings;rustdoc_include still finds the renamed final-code directory.
no-listing-05-fix-worker-neworno-listing-06-fix-threadpool-drop(greps return nothing outside the
listings/tree).AI assistance
Drafted with the help of Claude; reviewed line by line before
submission. rust-lang/book has no formal AI policy, so disclosure is
offered.