Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Replace #!/bin/sh with #!/bin/bash#50

Open
vi wants to merge 1 commit into
rust-lang-deprecated:masterfrom
vi:patch-1
Open

Replace #!/bin/sh with #!/bin/bash#50
vi wants to merge 1 commit into
rust-lang-deprecated:masterfrom
vi:patch-1

Conversation

@vi

@vi vi commented Apr 3, 2016

Copy link
Copy Markdown

Should resolve #47.

@sanmai-NL

Copy link
Copy Markdown
Contributor

I strongly prefer to rewrite in portable shell code instead, or to not use a shell script at all for this (given the relative complexity of the script). How is rustup going to work satisfactorily on various platforms otherwise?

@vi

vi commented Apr 15, 2016

Copy link
Copy Markdown
Author

rustup.sh may be obsoleted in favour of rustup.rs, so serious rewrite may be in vain.

@sanmai-NL

sanmai-NL commented Apr 15, 2016

Copy link
Copy Markdown
Contributor

The script is not that non-portable at present at all. See e.g. this comment

Revised: if rustup.rs is a suitable replacement (soon) anyway, briefly depending on /bin/bash is better than the current situation anyway.

@sanmai-NL

Copy link
Copy Markdown
Contributor

@vi: I must have missed the announcement of the alternative tool in this repo? I hope this can be clarified so that you get to see a warning immediately when browsing this repo.

@vi

vi commented Apr 15, 2016

Copy link
Copy Markdown
Author

@sanmai-NL, Main rustup.rs discussion thread is here: https://internals.rust-lang.org/t/beta-testing-rustup-rs/3316/83

@brson

brson commented May 3, 2016

Copy link
Copy Markdown
Contributor

Sorry I've been ignoring this repo. From the linked issue, none of the bashisms seem fundamental. I'd rather just fix them. This script is likely to stick around for at least a few more months.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bashisms while #!/bin/sh

3 participants