Immixcons - #66
Draft
pliniker wants to merge 76 commits into
Draft
Conversation
…ng implemented, didn't fix
Replace the custom SimpleLogger implementation with the standard env_logger crate. This simplifies the codebase while maintaining all essential logging functionality. Key changes: - Add env_logger 0.11 as a dependency - Replace custom SimpleLogger with env_logger::Builder initialization - Migrate from EVALRS_LOG_FILE environment variable to standard RUST_LOG - Preserve compile-time log level filtering (Trace in debug, Error in release) - Reduce logging.rs from 111 lines to 21 lines Benefits: - No unsafe code needed for logging - Uses battle-tested standard library implementation - Full ecosystem integration with standard RUST_LOG variable - Easier maintenance and debugging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving to a conservative Immix implementation.
See https://www.cs.cornell.edu/courses/cs6120/2022sp/blog/conservative-gc/