fix(credserver): reject arbitary headers, empty server urls & cred-helper binaries with path separator#1785
Open
Swapnanil-Gupta wants to merge 2 commits into
Open
fix(credserver): reject arbitary headers, empty server urls & cred-helper binaries with path separator#1785Swapnanil-Gupta wants to merge 2 commits into
Swapnanil-Gupta wants to merge 2 commits into
Conversation
Swapnanil-Gupta
force-pushed
the
creds-fixes
branch
3 times, most recently
from
f00081b to
7ca31ab
Compare
Swapnanil-Gupta
changed the title
Swapnanil-Gupta
force-pushed
the
creds-fixes
branch
from
7ca31ab to
f94e371
Compare
Swapnanil-Gupta
commented
Jul 9, 2026
Swapnanil-Gupta
force-pushed
the
creds-fixes
branch
2 times, most recently
from
7155fd4 to
5441e9d
Compare
Swapnanil-Gupta
changed the title
credhelper names containing path separator Signed-off-by: Swapnanil-Gupta <swpnlg@amazon.com>
Signed-off-by: Swapnanil-Gupta <swpnlg@amazon.com>
Swapnanil-Gupta
force-pushed
the
creds-fixes
branch
from
5441e9d to
a845fe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
X-Finch-Env-*headers.credsStoredefined in DOCKER_CONFIG contains a path separator or not and reject requests if it does.serverparameter./as its CWD.cc @ayush-panta
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.