Repository navigation
Conversation
fdevans
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix correctly maps setup outcomes to exit codes and includes regression coverage for each outcome.
0 open findings
What changed in this PR
Fixes #652 by making rd projects scm setup return integer exit codes that picocli recognizes.
Changes:
- Returns 0 for success, 1 for unsuccessful setup, and 2 for server validation errors.
- Adds regression tests for all three outcomes.
| File | Description |
|---|---|
| rd-cli-tool/src/test/groovy/org/rundeck/client/tool/commands/projects/SCMSpec.groovy | Tests each setup exit code. |
| rd-cli-tool/src/main/java/org/rundeck/client/tool/commands/projects/SCM.java | Converts setup results to integer exit codes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ltamaster
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #652
rd projects scm setupreturned aboolean, which picocli ignores as an exit code, so failures exited 0. It now returns anint, matchingscm perform:Added
SCMSpectests for each exit code.