Repository navigation
Conversation
fdevans
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
The focused guard fixes the reported crash, preserves non-null behavior, and includes a regression test.
0 open findings
What changed in this PR
Fixes #650 by handling null execution descriptions, preventing crashes in formatted execution queries and ad-hoc basic summaries.
Changes:
- Returns an empty string when shortening a null description.
- Adds a regression test verifying the information map preserves the execution ID and returns an empty description.
| File | Description |
|---|---|
| rd-api-client/src/test/groovy/org/rundeck/client/api/model/ExecutionSpec.groovy | Tests information-map generation with a null description. |
| rd-api-client/src/main/java/org/rundeck/client/api/model/Execution.java | Guards against null before shortening descriptions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #650
Execution.shortened()calledindexOfon a null description, crashingrd executions query --outformat(and the ad-hoc basic summary). A null description now becomes an empty string.Added a Spock test in
ExecutionSpeccovering a null description.