[RUN-4890] Document ACE editor manual resize default change - #1954
Merged
Conversation
Updates the Code Editor Settings config reference for rundeck/rundeck#10551: guiAceEditorMinLines now defaults to 0 (manually resizable via drag handle) instead of auto-sizing, and guiAceEditorMaxLines only applies in auto-size mode. Also notes the default changes on Self-Hosted starting in Rundeck 6.3.0 (SaaS already has it), and removes a stray leftover merge-conflict marker in the same section. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
smartinellibenedetti
requested review from
a team
and
a lite review from Copilot
September 3, 2026 23:32
smartinellibenedetti
changed the title
Clarify auto-expand and scrollbar behavior for guiAceEditorMinLines/MaxLines, and align product naming in the tip with the "Runbook Automation Self-Hosted" convention used elsewhere in the docs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated docs contain a couple of clarity/correctness issues (property key reference and edition/version-specific defaults) that should be adjusted to avoid confusing or misleading readers.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
docs/administration/configuration/config-file-reference.md:1130
- The
guiAceEditorMaxLinesdescription referencesguiAceEditorMinLines, but the property key isrundeck.feature.guiAceEditorMinLines. Using the full key here avoids ambiguity for readers copying config values.
| `rundeck.feature.guiAceEditorMaxLines` | `0` | Only applies when `guiAceEditorMinLines` is non-zero. Caps how far the editor auto-expands: once content reaches this many lines, a scrollbar appears instead of the editor growing further. Set to `0` for unlimited. |
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
fdevans
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config-file-reference.mdfor rundeck/rundeck#10551 (RUN-4890):guiAceEditorMinLinesnow defaults to0, making the ACE editor manually resizable via drag handle instead of auto-sizing;guiAceEditorMaxLinesis clarified to only apply when auto-sizing is active (non-zeroguiAceEditorMinLines).12to0starting in Rundeck 6.3.0.=======) found in the same section, unrelated to this change.Test plan
🤖 Generated with Claude Code