chore: harden plugin operations and diagnostics#5
Merged
Conversation
Add secret-safe diagnostics, broader plugin validation and install smoke coverage, dependency monitoring, support templates, and operator guidance.
Validate both plugin manifests strictly, document fail-open behavior accurately, and bound current-version installation smoke tests.
Keep recovery tools available under invalid config, reject unsafe transports and redirects, and tighten validation and documentation.
amavashev
marked this pull request as ready for review
July 22, 2026 19:26
Contributor
Author
|
Reviewed with independent verification of every claim (same account, so a comment rather than a formal approval). LGTM — this is a genuine hardening pass, and every stated claim checks out. Verified by execution on the branch:
Verified by inspection:
Minor observations, non-blocking:
All 10 PR checks green. Ready to merge; after merge + v0.2.0 tag, the directory listing auto-mirrors the update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/cycles-budget-guard:doctorcommand backed by the production configuration parserSelf-review remediation
X-Cycles-API-Key; treat 3xx reserve responses as authoritative denials instead of fail-open outagesRepository settings already applied
mainwith pull-request, required-check, strict-up-to-date, and conversation-resolution requirementsValidation
npm run lintnpm run test:coverage— 81 tests; 96.24% statements, 92.50% branches, 100% functions, 97.46% linesnpx --yes @anthropic-ai/claude-code@2.1.217 plugin validate .claude-plugin/plugin.json --strictnpx --yes @anthropic-ai/claude-code@2.1.217 plugin validate .claude-plugin/marketplace.json --strictnpm run smoke:installRELEASE_TAG=v0.2.0 npm run check:metadatanpm audit --audit-level=moderate— 0 vulnerabilitiesgit diff --checkNotes
The doctor command never prints the API-key value and never adds a gate bypass. Exact Cycles tools remain the recursion-safe diagnostic path. Default fail-open behavior remains limited to 5xx responses, network failures, and the four-second timeout; invalid configuration, malformed responses, 3xx responses, and authoritative 4xx responses deny non-Cycles execution.