Skip to content

Add WPF/XAML binding audit guidance to R3 migration skill#559

Merged
runceel merged 1 commit into
mainfrom
runceel-r3-skill-wpf-binding-guidance
Jun 28, 2026
Merged

Add WPF/XAML binding audit guidance to R3 migration skill#559
runceel merged 1 commit into
mainfrom
runceel-r3-skill-wpf-binding-guidance

Conversation

@runceel

@runceel runceel commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Summary

Updates the migrating-reactiveproperty-to-r3 skill to give explicit guidance on WPF/XAML data binding when migrating to R3.

Changes

  • SKILL.md: Adds a new step "Audit WPF/XAML bindings" (renumbering Build/test/report to step 5). It instructs the agent to:
    • Search XAML for {Binding Xxx.Value} / ItemsSource="{Binding Xxx.Value}" after the mechanical rewrite.
    • Prefer BindableReactiveProperty<T> for UI-bound read/write properties.
    • Use ToReadOnlyBindableReactiveProperty(...) exposed as IReadOnlyBindableReactiveProperty<T> for UI-bound read-only properties.
    • Treat a successful build as insufficient — every XAML .Value binding must be backed by a bindable R3 property.
  • references/rules.json: Expands the notes for the relevant rules (RP-PROP-SLIM, RP-READONLY-PROP-SLIM, RP-PROP-BINDING, RP-FROM-OBSERVABLE) with the same WPF binding guidance.

Notes

  • BOM was added to both files to match the repo convention (UTF-8 with BOM).
  • Docs/skill-only change; no library code affected.

Adds a dedicated step to audit WPF/XAML .Value bindings after the mechanical rewrite, and clarifies in rules.json that XAML-bound read/write properties should use BindableReactiveProperty<T> and read-only ones should use ToReadOnlyBindableReactiveProperty(...) exposed as IReadOnlyBindableReactiveProperty<T>.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@runceel runceel merged commit 23a0773 into main Jun 28, 2026
2 checks passed
@runceel runceel deleted the runceel-r3-skill-wpf-binding-guidance branch June 28, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants