Enhanced Italian Localization Updated - #1154
Open
albyalex96 wants to merge 9 commits into
Open
Conversation
Author
|
@rukamori could you please approve workflow so i can get a test version of the app with my branch? i don't really know how to build it myself ( as i don't know how to properly set up all the keys required for the build ) . i would use that version till this pr is merged ( hopefully 🤣 ) . peace <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Adds a complete Italian localization by introducing
strings-it.xmlwith translations for every string in the basestrings.xml. The translation preserves product and service names as-is (ArchiveTune, Discord, YouTube, Last.fm, Libre.fm, ListenBrainz, Spotify, Cast, Rich Presence, PO Token, etc.) and adjusts plural forms to Italian grammar rules. No app behavior, code, or existing resources are modified; devices with an Italian locale will now fall back to the new Italian strings instead of English.Linked Work
strings.xmlChange Type
Affected Surfaces
:app:core:lyrics:lastfm:canvas:shazamkit:spotifycorestrings-it.xmlresource file (Italian string resources only; no code touched)Screenshots / Recordings
Not applicable — this is a resource-only change with no visual or UI difference in the default (English) locale.
Behavior Notes
itwill now resolve UI strings fromstrings-it.xml; all other locales keep the basestrings.xmlvalues.%s,%d,%1$s,%1$d,%1$+.1f dB,%1$.1f kHz, etc.), escaped quotes (\u0022), escaped apostrophes (\'), and multiline\nsequences are preserved verbatim.one/other) were adapted to Italian pluralization; invariant nouns such asalbumandplaylistkeep a single form in both quantities.external_downloader_not_configured(Settings â†' Player) is rendered correctly asImpostazioni → Playerin the Italian file only; the base file is left untouched.Architecture Checklist
Not applicable — no source, state, or data-flow changes.
Loading,Success,Empty, andErrorwhere this PR introduces or changes screen state.runBlockingis introduced in app execution paths.Compose / Material Checklist
Not applicable — no UI code changes.
collectAsStateWithLifecycle().@Immutableor@Stable.keyvalues and explicitcontentType.derivedStateOfwhere appropriate.stringResource()and duplicated visible strings on the same screen are avoided.WindowInsetscorrectly when this PR changes screen layout.Concurrency / Performance Checklist
Not applicable — no runtime code changes.
viewModelScopeor an existing lifecycle-owned application/service scope.Dispatchers.IOorDispatchers.Default.Data / Persistence Checklist
Not applicable — no persistence, database, network, or DTO changes.
app/schemas.Playback / Integration Checklist
Not applicable — no playback or integration behavior changes.
universal,arm64,armeabi,x86, andx86_64variants.Localization / Assets Checklist
strings.xmlis untouched; all of its keys are translated in the newstrings-it.xml.)Privacy / Security Checklist
Not applicable — no runtime, network, or logging code changes. The new file contains only localized UI text and no secrets or paths.
Verification
nameattributes betweenstrings.xmlandstrings-it.xml— 0 missing, 0 extra keys.strings-it.xmlparses successfully as well-formed XML.%s,%d,%1$s,%1$d,%1$+.1f dB,%1$.1f kHz,%1$d%%,%1$s/s,\n,\u0022, and\'sequences match the base file.Reviewer Focus
strings-it.xmlfor natural Italian phrasing and grammatical gender/number agreement (e.g.,%d selezionati, pluralbrano/brani, invariantalbum/playlist).Palettenames (e.g.,Spotify,YouTube,Sakura,Synthwave,Cyberpunk) stay as intended brand terms.String.format/resource formatting does not crash at runtime.Release Notes
ArchiveTune is now fully translated into Italian.